From 2673983220cb0ee009953410b6f16b226eb4ba7b Mon Sep 17 00:00:00 2001
From: Chris Cannam <cannam@all-day-breakfast.com>
Date: Fri, 27 May 2022 15:29:28 +0100
Subject: [PATCH] I think this check was only necessary because of our wrong
 handling of pitch scale

---
 src/finer/R3StretcherImpl.cpp | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/finer/R3StretcherImpl.cpp b/src/finer/R3StretcherImpl.cpp
index 0a19320..ae1c3e6 100644
--- a/src/finer/R3StretcherImpl.cpp
+++ b/src/finer/R3StretcherImpl.cpp
@@ -175,9 +175,9 @@ R3StretcherImpl::calculateHop()
 {
     double ratio = getEffectiveRatio();
     double proposedOuthop = 256.0;
-    if (proposedOuthop * m_pitchScale > 2048.0) {
-        proposedOuthop = 2048.0 / m_pitchScale;
-    }
+//!!!    if (proposedOuthop * m_pitchScale > 2048.0) {
+//        proposedOuthop = 2048.0 / m_pitchScale;
+//    }
     double inhop = 1.0;
     
     if (ratio > 1.0) {
@@ -192,6 +192,8 @@ R3StretcherImpl::calculateHop()
 
     m_inhop = int(round(inhop));
 
+    //!!! but if we now have outhop > 4096 ever, we will crash, so we must check
+
 //    std::cout << "R3StretcherImpl::calculateHop: inhop = " << m_inhop << ", proposed outhop = " << proposedOuthop << ", mean outhop = " << m_inhop * ratio << std::endl;
 }