david/librubberband
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix and test stack overflow in R2 stretcher's time-domain smoothing option with long input buffers. The code in question is non-RT and has no need to be using stack allocation here at all. Thanks to Peter Sobot for the report.

Browse Source
This commit is contained in:
Chris Cannam
2024-06-26 11:05:19 +01:00
parent 836330b1a1
commit 832f577acb
3 changed files with 45 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/faster/StretcherProcess.cpp
View File

@@ -236,6 +236,9 @@ R2Stretcher::consumeChannel(size_t c,
inbuf.write(cd.resamplebuf, toWrite);
cd.inCount += samples;
m_log.log(2, "consumeChannel: wrote to inbuf from resamplebuf, inCount now", toWrite, cd.inCount);
return samples;
} else {
@@ -249,6 +252,9 @@ R2Stretcher::consumeChannel(size_t c,
inbuf.write(input, toWrite);
cd.inCount += toWrite;
m_log.log(2, "consumeChannel: wrote to inbuf from input, inCount now", toWrite, cd.inCount);
return toWrite;
}
}
@@ -340,7 +346,7 @@ R2Stretcher::processOneChunk()
return false;
}
ChannelData &cd = *m_channelData[c];
m_log.log(3, "read space and draining", cd.inbuf->getReadSpace(), cd.draining);
m_log.log(2, "read space and draining", cd.inbuf->getReadSpace(), cd.draining);
if (!cd.draining) {
size_t ready = cd.inbuf->getReadSpace();
assert(ready >= m_aWindowSize || cd.inputSize >= 0);