david/librubberband
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Slacken some test expectations appropriately for non-builtin resampler, after reviewing the output

Browse Source
This commit is contained in:
Chris Cannam
2023-04-05 11:51:26 +01:00
parent b9f2b58e1f
commit dfef60c486
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/test/TestStretcher.cpp
View File

@@ -380,9 +380,11 @@ static void sinusoid_realtime(RubberBandStretcher::Options options,
int slack = 0; int slack = 0;
if (options & RubberBandStretcher::OptionEngineFiner) { if (options & RubberBandStretcher::OptionEngineFiner) {
if (options & RubberBandStretcher::OptionWindowShort) { if (chunk == 19) {
slack = 5;
} else if (options & RubberBandStretcher::OptionWindowShort) {
slack = 2; slack = 2;
} else if (chunk == 0 || chunk == 19 || highSpeedPitch) { } else if (chunk == 0 || highSpeedPitch) {
slack = 1; slack = 1;
} }
} else { } else {
@@ -416,6 +418,8 @@ static void sinusoid_realtime(RubberBandStretcher::Options options,
if (!(options & RubberBandStretcher::OptionEngineFiner) || if (!(options & RubberBandStretcher::OptionEngineFiner) ||
(options & RubberBandStretcher::OptionWindowShort)) { (options & RubberBandStretcher::OptionWindowShort)) {
maxUnder = 0.2; maxUnder = 0.2;
} else if (chunk == 19) {
maxUnder = 0.15;
} }
BOOST_TEST(rms - expected < maxOver); BOOST_TEST(rms - expected < maxOver);
@@ -941,24 +945,24 @@ static void impulses_realtime(RubberBandStretcher::Options options,
if (out[i] > max) { max = out[i]; peak2 = i; } if (out[i] > max) { max = out[i]; peak2 = i; }
} }
// These limits aren't alarming, but it be worth tightening them // These limits aren't alarming, but it may be worth tightening
// and and taking a look at the waveforms // them and and taking a look at the waveforms
BOOST_TEST(peak0 < int(ceil(200 * timeRatio))); BOOST_TEST(peak0 < int(ceil(200 * timeRatio)));
BOOST_TEST(peak0 > int(ceil(50 * timeRatio))); BOOST_TEST(peak0 > int(ceil(50 * timeRatio)));
BOOST_TEST(peak1 < int(ceil(5070 * timeRatio))); BOOST_TEST(peak1 < int(ceil(5070 * timeRatio)));
BOOST_TEST(peak1 > int(ceil(4840 * timeRatio))); BOOST_TEST(peak1 > int(ceil(4640 * timeRatio)));
BOOST_TEST(peak2 < int(ceil(9970 * timeRatio))); BOOST_TEST(peak2 < int(ceil(9970 * timeRatio)));
BOOST_TEST(peak2 > int(ceil(9770 * timeRatio))); BOOST_TEST(peak2 > int(ceil(9770 * timeRatio)));
/* if (printDebug) {
std::cout << "ms\tV" << std::endl; std::cout << "#sample\tV" << std::endl;
for (int i = 0; i < n*2; ++i) { for (int i = 0; i < n*2; ++i) {
std::cout << i << "\t" << out[i] << std::endl; std::cout << "#" << i << "\t" << out[i] << std::endl;
}
} }
*/
} }
BOOST_AUTO_TEST_CASE(impulses_slow_samepitch_realtime_finer) BOOST_AUTO_TEST_CASE(impulses_slow_samepitch_realtime_finer)