From fb75aa36f69e4686a4f98b0c05ab24cac2ab59d0 Mon Sep 17 00:00:00 2001 From: Chris Cannam Date: Tue, 14 Jun 2022 10:01:11 +0100 Subject: [PATCH] Using the instantaneous ratio here seems more proper, but it causes audible interference when using tiny shift ratios such that the hop flips back and forth between two adjacent values. Let's try using the more stable effective ratio, and see if the window smoothing is sufficient --- src/finer/R3StretcherImpl.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/finer/R3StretcherImpl.cpp b/src/finer/R3StretcherImpl.cpp index 36b8509..21d13e6 100644 --- a/src/finer/R3StretcherImpl.cpp +++ b/src/finer/R3StretcherImpl.cpp @@ -814,10 +814,9 @@ R3StretcherImpl::analyseChannel(int c, int inhop, int prevInhop, int prevOuthop) std::cout << std::endl; } */ - double instantaneousRatio = double(prevOuthop) / double(prevInhop); bool specialCaseUnity = true; - m_guide.updateGuidance(instantaneousRatio, + m_guide.updateGuidance(getEffectiveRatio(), classifyScale->mag.data(), classifyScale->prevMag.data(), cd->readahead.mag.data(),