david/librubberband
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

I think this check was only necessary because of our wrong handling of pitch scale

Browse Source
This commit is contained in:
Chris Cannam
2022-05-27 15:29:28 +01:00
parent ce64122ffe
commit 2673983220
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/finer/R3StretcherImpl.cpp
View File

@@ -175,9 +175,9 @@ R3StretcherImpl::calculateHop()
{ {
double ratio = getEffectiveRatio(); double ratio = getEffectiveRatio();
double proposedOuthop = 256.0; double proposedOuthop = 256.0;
if (proposedOuthop * m_pitchScale > 2048.0) { //!!! if (proposedOuthop * m_pitchScale > 2048.0) {
proposedOuthop = 2048.0 / m_pitchScale; // proposedOuthop = 2048.0 / m_pitchScale;
} // }
double inhop = 1.0; double inhop = 1.0;
if (ratio > 1.0) { if (ratio > 1.0) {
@@ -192,6 +192,8 @@ R3StretcherImpl::calculateHop()
m_inhop = int(round(inhop)); m_inhop = int(round(inhop));
//!!! but if we now have outhop > 4096 ever, we will crash, so we must check
// std::cout << "R3StretcherImpl::calculateHop: inhop = " << m_inhop << ", proposed outhop = " << proposedOuthop << ", mean outhop = " << m_inhop * ratio << std::endl; // std::cout << "R3StretcherImpl::calculateHop: inhop = " << m_inhop << ", proposed outhop = " << proposedOuthop << ", mean outhop = " << m_inhop * ratio << std::endl;
} }