david/librubberband
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Excessive clipping can happen with perfectly normal input - make the warning less scary

Browse Source
This commit is contained in:
Chris Cannam
2022-06-29 14:43:59 +01:00
parent 3060f37ae8
commit fb8f021a1a
1 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
main/main.cpp
View File

@@ -865,19 +865,21 @@ int main(int argc, char **argv)
}
if (clipping) {
if (!quiet) {
cerr << "NOTE: Clipping detected at output sample "
<< countOut << ", restarting with "
<< "reduced gain of " << gain
<< " (supply --ignore-clipping to avoid this)" << endl;
}
const float mingain = 0.75f;
if (gain < mingain) {
cerr << "WARNING: Clipped values were implausibly high: "
<< "something wrong with input or process - "
<< "not reducing gain below " << mingain << endl;
cerr << "NOTE: Clipping detected at output sample "
<< countOut << ", but not reducing gain as it would "
<< "mean dropping below minimum " << mingain << endl;
gain = mingain;
ignoreClipping = true;
} else {
if (!quiet) {
cerr << "NOTE: Clipping detected at output sample "
<< countOut << ", restarting with "
<< "reduced gain of " << gain
<< " (supply --ignore-clipping to avoid this)"
<< endl;
}
}
successful = false;
break;
@@ -983,7 +985,11 @@ int main(int argc, char **argv)
if (!quiet) {
cerr << "in: " << countIn << ", out: " << countOut << ", ratio: " << float(countOut)/float(countIn) << ", ideal output: " << lrint(countIn * ratio) << ", error: " << abs(lrint(countIn * ratio) - int(countOut)) << endl;
cerr << "in: " << countIn << ", out: " << countOut
<< ", ratio: " << float(countOut)/float(countIn)
<< ", ideal output: " << lrint(countIn * ratio)
<< ", error: " << abs(lrint(countIn * ratio) - int(countOut))
<< endl;
#ifdef _WIN32
RubberBand::